Cover force_mpo in simple update test#350
Merged
leburgel merged 3 commits intoQuantumKitHub:masterfrom Apr 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
Yue-Zhengyuan
commented
Apr 10, 2026
Yue-Zhengyuan
changed the title
force_mpo in simple update test
leburgel
approved these changes
Apr 10, 2026
Member
|
I'll merge as is. The example test failure should be fixed by #353, and the gradient test timeout will require more work to sort out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes an error that will never be raised.
PEPSKit.jl/src/algorithms/time_evolution/simpleupdate.jl
Lines 143 to 148 in cb2c179
As
length(sites) == 2, the error will not be raised and is redundant.It also updated the finite-T SU test with transverse field Ising model to test
force_mpo = true, i.e. applying a nearest neighbor 2-site gate as an MPO (instead of a rank-4 TensorMap) on an iPEPO.